Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix virtual mocks not being unmockable after previously being mocked #8396

Merged
merged 2 commits into from Apr 30, 2019

Conversation

Projects
None yet
4 participants
@Blasz
Copy link
Contributor

commented Apr 30, 2019

Summary

Fixes #8395 where virtual mocks could not be unmocked after previously being mocked.

Test plan

Repro steps are in a test case and now pass.

@codecov-io

This comment has been minimized.

Copy link

commented Apr 30, 2019

Codecov Report

Merging #8396 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8396      +/-   ##
==========================================
- Coverage   62.34%   62.33%   -0.02%     
==========================================
  Files         266      266              
  Lines       10738    10735       -3     
  Branches     2612     2610       -2     
==========================================
- Hits         6695     6692       -3     
  Misses       3460     3460              
  Partials      583      583
Impacted Files Coverage Δ
packages/jest-runtime/src/index.ts 69.39% <ø> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b8382...5510a91. Read the comment docs.

@SimenB

SimenB approved these changes Apr 30, 2019

Copy link
Collaborator

left a comment

Thanks!

@SimenB SimenB merged commit 391c4e2 into facebook:master Apr 30, 2019

3 of 11 checks passed

ci/circleci: test-jest-circus CircleCI is running your tests
Details
ci/circleci: test-node-10 CircleCI is running your tests
Details
ci/circleci: test-node-11 CircleCI is running your tests
Details
ci/circleci: test-node-6 CircleCI is running your tests
Details
ci/circleci: test-node-8 CircleCI is running your tests
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
deploy/netlify Deploy preview processing.
Details
facebook.jest in progress
Details
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.