Improve handling of .gitignore files. (#306)

* Omit comments from list of patterns. * Support .gitignore files with \r\n linebreaks.
facebook · Mar 6, 2019 · ec3ab98 · ec3ab98
1 parent 6dd0eba
commit ec3ab98
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/ignoreFiles.js b/src/ignoreFiles.js
@@ -12,7 +12,7 @@ const matchers = [];
  * @see {@linkplain https://git-scm.com/docs/gitignore#_pattern_format}
  */
 function addIgnorePattern(val) {
-  if (val && typeof val === 'string') {
+  if (val && typeof val === 'string' && val[0] !== '#') {
     let pattern = val;
     if (pattern.indexOf('/') === -1) {
       matchers.push('**/' + pattern);
@@ -51,7 +51,7 @@ function addIgnoreFromFile(input) {
     const stats = fs.statSync(config);
     if (stats.isFile()) {
       const content = fs.readFileSync(config, 'utf8');
-      lines = lines.concat(content.split('\n'));
+      lines = lines.concat(content.split(/\r?\n/));
     }
   });