template.expression should not parse string without interpolation as statement #196
Conversation
…statement
If a template doesn't have any interpolation parameters (e.g., expression`function() {}`),
it should be also surrounded by () to force parsing as expression.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This indeed fixes a bug and looks good to merge. |
Let's parse a function expression with
jscodeshift.template.expression:This code is a valid expression, but not a valid statement -- a function needs to have a name to be a valid statement.
template.expressionsurrounds the code with()to force parsing as expression. However, it fails to do so if the template string doesn't have any interpolation parameters. Therefore, the above function expression fails to parse.This PR fixes that bug -- the length of the
templatearray is incorrectly checked. It should check forlength === 1instead oflength === 0. Moreover, a special case forlength === 1is not even necessary.