fix: preserve file extension for remote file #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my first contribution to this project - let me know if I'm missing anything in my commit! |
fkling
reviewed
Apr 30, 2019
There is behavior in this program that depends on the extension of the transformFile, notably how babel runs (or doesn't). There was a bug when requesting a remote transformFile authored as an ES6 module because of the temp filename being used. This commit preserves the original file extension used when writing the remote file to the temp one.
samselikoff
force-pushed
the
fix-remote-transform-file
branch
from
cb8c777
to
f2e4e6b
Compare
|
Nice, didn't know about that! Updated. |
|
@samselikoff Is the error you are talking about is the same as #316 |
|
Yep, this should be the fix! |
|
It does indeed fix #316! 🙂 npx samselikoff/jscodeshift#fix-remote-transform-file -t https://url.here/codemod.js tests |
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is behavior in this program that depends on the extension
of the transformFile, notably how babel runs (or doesn't).
There was a bug when requesting a remote transformFile authored as
an ES6 module because of the temp filename being used.
This commit preserves the original file extension used when writing
the remote file to the temp one.
Fixes #316