New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support newer TypeScript syntax #410
Conversation
I think there was an issue with the Travis-CI run. It says it failed, but the logs are all null... |
Is the travis failure related to travis-ci.org shutdown? |
@Daniel15, any possibility we could work to get this merged? This is currently blocking us (and presumably many others) from being able to use jscodeshift |
Sure! This looks reasonable to me. However, it looks like there's some merge conflicts. @wdoug If you rebase this and ping me again, I can merge it :)
Internally at Facebook we use the Flow parser which is probably why nobody has noticed this. |
Hmm. @Daniel15, I believe I already resolved those... at least GitHub is telling me there are no conflicts: Maybe your page was cached from earlier? |
@wdoug Huh, that's weird, because I still see this today (on a different PC so it shouldn't be caching): |
Hmm. @Daniel15 do y'all only support rebase and merge (as opposed to merge commits or squash and merge)? If so, I could see how that would be a problem given that I merged in changes on |
Ah, good point, we normally use rebase and merge but I think I can use a merge commit for this. Let me see... |
I can squash my commits if you would like |
@Daniel15 how do y'all manage your release process for this project? Just wondering when we might be able to update the version dependency for jscodeshift in things like |
I'll push an update now 😃 I've never done it before though |
Published as 0.12.0. Seems like the publish worked properly to me, but please let me know if anything looks amiss. Thanks for your contribution! |
I see it listed as version |
@wdoug That's likely because of caching on the npm site 😃 Yarn just pulls packages from npm. The Yarn site uses a search index provided by Algolia whereas npm uses something else |
Okay, cool. I thought they came from the same place but wasn't sure if something changed there. Thanks! |
This builds on top of @mfeckie's pull request #329 to update babel dependencies to support newer syntax updates.
This closes #409