Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer TypeScript syntax #410

Merged
merged 9 commits into from Apr 21, 2021

Conversation

wdoug
Copy link
Contributor

@wdoug wdoug commented Jan 26, 2021

This builds on top of @mfeckie's pull request #329 to update babel dependencies to support newer syntax updates.

This closes #409

@wdoug
Copy link
Contributor Author

wdoug commented Jan 26, 2021

I think there was an issue with the Travis-CI run. It says it failed, but the logs are all null...

@TheMcMurder
Copy link

Is the travis failure related to travis-ci.org shutdown?

@wdoug
Copy link
Contributor Author

wdoug commented Apr 20, 2021

@Daniel15, any possibility we could work to get this merged? This is currently blocking us (and presumably many others) from being able to use jscodeshift

@Daniel15
Copy link
Member

Sure! This looks reasonable to me. However, it looks like there's some merge conflicts. @wdoug If you rebase this and ping me again, I can merge it :)

This is currently blocking us (and presumably many others) from being able to use jscodeshift

Internally at Facebook we use the Flow parser which is probably why nobody has noticed this.

@wdoug
Copy link
Contributor Author

wdoug commented Apr 21, 2021

Hmm. @Daniel15, I believe I already resolved those... at least GitHub is telling me there are no conflicts:
Screen Shot 2021-04-21 at 8 06 23 AM

Maybe your page was cached from earlier?

@Daniel15
Copy link
Member

@wdoug Huh, that's weird, because I still see this today (on a different PC so it shouldn't be caching):

image

@wdoug
Copy link
Contributor Author

wdoug commented Apr 21, 2021

Hmm. @Daniel15 do y'all only support rebase and merge (as opposed to merge commits or squash and merge)? If so, I could see how that would be a problem given that I merged in changes on master instead of rebasing them. I was planning on keeping it that way to keep the original commits that @mfeckie wrote, but if need be I can squash the commits on this branch if we think that might resolve the issue.

@Daniel15
Copy link
Member

Daniel15 commented Apr 21, 2021

Ah, good point, we normally use rebase and merge but I think I can use a merge commit for this. Let me see...

@wdoug
Copy link
Contributor Author

wdoug commented Apr 21, 2021

I can squash my commits if you would like

@Daniel15 Daniel15 merged commit 788d6e1 into facebook:master Apr 21, 2021
@wdoug wdoug deleted the support-typescript-3.8 branch April 21, 2021 19:15
@wdoug
Copy link
Contributor Author

wdoug commented Apr 21, 2021

@Daniel15 how do y'all manage your release process for this project? Just wondering when we might be able to update the version dependency for jscodeshift in things like ts-migrate (related issue)?

@Daniel15
Copy link
Member

Daniel15 commented Apr 21, 2021

I'll push an update now 😃 I've never done it before though

@Daniel15 Daniel15 mentioned this pull request Apr 21, 2021
@Daniel15
Copy link
Member

Published as 0.12.0. Seems like the publish worked properly to me, but please let me know if anything looks amiss. Thanks for your contribution!

@wdoug
Copy link
Contributor Author

wdoug commented Apr 21, 2021

I see it listed as version 0.12.0 on Yarn's packages, but it still shows 0.11.0 on npm's page. For my immediate use case that doesn't matter, but it seems like it would be nice to also have update on npm if it isn't already.

@Daniel15
Copy link
Member

Daniel15 commented Apr 21, 2021

@wdoug That's likely because of caching on the npm site 😃 Yarn just pulls packages from npm. The Yarn site uses a search index provided by Algolia whereas npm uses something else

@wdoug
Copy link
Contributor Author

wdoug commented Apr 21, 2021

Okay, cool. I thought they came from the same place but wasn't sure if something changed there. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error on TypeScript's import type syntax
6 participants