Fix processes count and chunk size for run-in-band mode #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkling
added a commit
that referenced
this pull request
Mar 14, 2016
Fix processes count and chunk size for run-in-band mode
|
Released with v0.3.15. |
euphocat
pushed a commit
to euphocat/jscodeshift
that referenced
this pull request
Oct 22, 2017
…acebook#96) * Don't put comments on JSXIdentifier nodes in create-element-to-jsx Previously, this code: ```js React.createElement( Foo, // This is a comment {bar: baz} ); ``` would change to this code: ```js <// This is a comment Foo bar={baz} /> ``` This is technically correct, but really ugly, so this commit changes the script to reposition the comment to be on the outer JSXElement instead of the JSXIdentifier directly. As we traverse the first arg to `React.createElement`, we collect all comments and add them to the array of comments that we'll eventually add to the outer JSXElement. Note that this depends on a fix to recast that was just released in version 0.11.22. See this PR for more details: benjamn/recast#364 Without that change, the repositioned comment could sometimes cause the resulting code to be incorrect if it's at the start of the expression part of a return statement. The latest jscodeshift has recast 0.11.22 in its version range, so a fresh install makes everything work, but an old install might fail. * Update jscodeshift in package.json to try to get the build to work Also alphabetize the dependencies since that's what `npm install --save` does. * Update yarn.lock so recast gets updated This was done with `yarn remove jscodeshift` and `yarn add jscodeshift`, so it updated all jscodeshift dependencies to latest, including recast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The worker was being called more than once when in run-in-band mode.