Use inExpression in a nullsafe way #417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
nreid260
force-pushed
the
in_expression
branch
from
be69526
to
5b7ef97
Compare
|
@hick209 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Is this fixing an issue that you have seem or just a precaution? |
|
I mostly care because our internal build has some additional null checking for JDK classes, which is triggering on this code. However, this version will also crash on unbalanced use of the stack, which is nice. |
|
Ran into merge conflicts while trying to land this. @nreid260 would you mind rebasing it? |
|
Nevermind, it was simple enough. I've rebased it |
lancethomps
added a commit
to lancethomps/ktfmt
that referenced
this pull request
Oct 9, 2023
* upstream/main: Add unit tests to capture line break behavior on type specifiers Plugin doesn't work with if "Only VCS changed text" is selected from code-reformat settings (facebook#386) Bump version to 0.47-SNAPSHOT Bump version to 0.46 Fix indentation of trailing comments in a bunch of cases (facebook#418) Adjust .editorconfig for kotlinlang style for IntelliJ to better align with ktfmt (facebook#412) Bump Kotlin version to 1.8.22 Bump version to 0.46-SNAPSHOT Bump version to 0.45 Bump word-wrap from 1.2.3 to 1.2.4 in /website (facebook#410) Use inExpression in a nullsafe way (facebook#417) Update ktfmt component on FBS:master Back out "Improve argsfile support" Improve argsfile support Fix double indentation in Elvis chains (facebook#416) Daily `arc lint --take KTFMT` Remove TypeNameClassifier Support context receivers (facebook#400) Added link to live playground directly into README file Keep imports from the same package if the name is overloaded (facebook#414)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peekLast is a JDK method using platform types for the return value.