Further refactoring on CLI #476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 9, 2024 16:13
Checking whether we have a single filename '-' or multiple files, none of which are '-' is parsing and should be part of the parsing step
Similarly to 5b97b8e, this logic is part of parsing the CLI args
The tests in MainTest.kt will fail since the JVM is terminated by the exitProcess() call. In addition, many of the tests want to check the return code so exiting directly is a bad idea.
facebook-github-bot
added
the
CLA Signed
|
I've got a follow on PR ready to go which adds |
|
As this one breaks the current CLI API contract, let's land it last as make it part of the 1.0.0 release. Do you think we could land the |
This reverts commit b2e5944.
|
I've reverted the commit that adds |
Closed
|
SGTM 😃 |
hick209
approved these changes
Jun 10, 2024
|
@hick209 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
Summary: This was missed on the changes from #476, but luckily our internal tests caught it when I tried to sent out a new release. Reviewed By: strulovich Differential Revision: D58528471 fbshipit-source-id: ea4824b295f452b1dc0f7d868664e6792ba07c9c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't add any features or fix any bugs, but does change the style option from
--dropbox-styleto--style=dropbox(and similarly for the other styles) as discussed in #391.