[*] Chore: Fix all new lint warnings, plus manual exports clean-up (#…

…5979)
facebook · May 10, 2024 · 081188c · 081188c
1 parent b5fa87d
commit 081188c
Show file tree

Hide file tree

Showing 95 changed files with 557 additions and 626 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -82,6 +82,7 @@ module.exports = {
               // @lexical/yjs
               'createBinding',
             ],
+            isLexicalProvider: ['updateEditor'],
             isSafeDollarFunction: '$createRootNode',
           }),
         ],

diff --git a/examples/vanilla-js-plugin/src/emoji-plugin/EmojiPlugin.ts b/examples/vanilla-js-plugin/src/emoji-plugin/EmojiPlugin.ts
@@ -11,7 +11,7 @@ import {LexicalEditor, TextNode} from 'lexical';
 import {$createEmojiNode} from './EmojiNode';
 import findEmoji from './findEmoji';
 
-function textNodeTransform(node: TextNode): void {
+function $textNodeTransform(node: TextNode): void {
   if (!node.isSimpleText() || node.hasFormat('code')) {
     return;
   }
@@ -46,5 +46,5 @@ function textNodeTransform(node: TextNode): void {
 export function registerEmoji(editor: LexicalEditor): () => void {
   // We don't use editor.registerUpdateListener here as alternative approach where we rely
   // on update listener is highly discouraged as it triggers an additional render (the most expensive lifecycle operation).
-  return editor.registerNodeTransform(TextNode, textNodeTransform);
+  return editor.registerNodeTransform(TextNode, $textNodeTransform);
 }
diff --git a/examples/vanilla-js-plugin/src/prepopulatedRichText.ts b/examples/vanilla-js-plugin/src/prepopulatedRichText.ts
@@ -7,7 +7,7 @@
  */
 import {$createParagraphNode, $createTextNode, $getRoot} from 'lexical';
 
-export default function prepopulatedRichText() {
+export default function $prepopulatedRichText() {
   const root = $getRoot();
   if (root.getFirstChild() !== null) {
     return;

diff --git a/examples/vanilla-js/src/prepopulatedRichText.ts b/examples/vanilla-js/src/prepopulatedRichText.ts
@@ -8,7 +8,7 @@
 import {$createHeadingNode, $createQuoteNode} from '@lexical/rich-text';
 import {$createParagraphNode, $createTextNode, $getRoot} from 'lexical';
 
-export default function prepopulatedRichText() {
+export default function $prepopulatedRichText() {
   const root = $getRoot();
   if (root.getFirstChild() !== null) {
     return;

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/lexical-code/src/CodeHighlighter.ts b/packages/lexical-code/src/CodeHighlighter.ts
@@ -201,7 +201,7 @@ export function getEndOfCodeInLine(
   return lastNode;
 }
 
-function textNodeTransform(
+function $textNodeTransform(
   node: TextNode,
   editor: LexicalEditor,
   tokenizer: Tokenizer,
@@ -275,7 +275,7 @@ function codeNodeTransform(
   // in its final state
   editor.update(
     () => {
-      updateAndRetainSelection(nodeKey, () => {
+      $updateAndRetainSelection(nodeKey, () => {
         const currentNode = $getNodeByKey(nodeKey);
 
         if (!$isCodeNode(currentNode) || !currentNode.isAttached()) {
@@ -287,7 +287,7 @@ function codeNodeTransform(
           code,
           currentNode.getLanguage() || tokenizer.defaultLanguage,
         );
-        const highlightNodes = getHighlightNodes(tokens);
+        const highlightNodes = $getHighlightNodes(tokens);
         const diffRange = getDiffRange(
           currentNode.getChildren(),
           highlightNodes,
@@ -311,7 +311,7 @@ function codeNodeTransform(
   );
 }
 
-function getHighlightNodes(
+function $getHighlightNodes(
   tokens: Array<string | Token>,
   type?: string,
 ): LexicalNode[] {
@@ -334,9 +334,9 @@ function getHighlightNodes(
     } else {
       const {content} = token;
       if (typeof content === 'string') {
-        nodes.push(...getHighlightNodes([content], token.type));
+        nodes.push(...$getHighlightNodes([content], token.type));
       } else if (Array.isArray(content)) {
-        nodes.push(...getHighlightNodes(content, token.type));
+        nodes.push(...$getHighlightNodes(content, token.type));
       }
     }
   }
@@ -346,7 +346,7 @@ function getHighlightNodes(
 
 // Wrapping update function into selection retainer, that tries to keep cursor at the same
 // position as before.
-function updateAndRetainSelection(
+function $updateAndRetainSelection(
   nodeKey: NodeKey,
   updateFn: () => boolean,
 ): void {
@@ -510,7 +510,7 @@ function $getCodeLines(
   return lines;
 }
 
-function handleTab(shiftKey: boolean): null | LexicalCommand<void> {
+function $handleTab(shiftKey: boolean): null | LexicalCommand<void> {
   const selection = $getSelection();
   if (!$isRangeSelection(selection) || !$isSelectionInCode(selection)) {
     return null;
@@ -564,7 +564,7 @@ function handleTab(shiftKey: boolean): null | LexicalCommand<void> {
   return tabOrOutdent;
 }
 
-function handleMultilineIndent(type: LexicalCommand<void>): boolean {
+function $handleMultilineIndent(type: LexicalCommand<void>): boolean {
   const selection = $getSelection();
   if (!$isRangeSelection(selection) || !$isSelectionInCode(selection)) {
     return false;
@@ -627,7 +627,7 @@ function handleMultilineIndent(type: LexicalCommand<void>): boolean {
   return true;
 }
 
-function handleShiftLines(
+function $handleShiftLines(
   type: LexicalCommand<KeyboardEvent>,
   event: KeyboardEvent,
 ): boolean {
@@ -759,7 +759,7 @@ function handleShiftLines(
   return true;
 }
 
-function handleMoveTo(
+function $handleMoveTo(
   type: LexicalCommand<KeyboardEvent>,
   event: KeyboardEvent,
 ): boolean {
@@ -834,15 +834,15 @@ export function registerCodeHighlighting(
       codeNodeTransform(node, editor, tokenizer as Tokenizer),
     ),
     editor.registerNodeTransform(TextNode, (node) =>
-      textNodeTransform(node, editor, tokenizer as Tokenizer),
+      $textNodeTransform(node, editor, tokenizer as Tokenizer),
     ),
     editor.registerNodeTransform(CodeHighlightNode, (node) =>
-      textNodeTransform(node, editor, tokenizer as Tokenizer),
+      $textNodeTransform(node, editor, tokenizer as Tokenizer),
     ),
     editor.registerCommand(
       KEY_TAB_COMMAND,
       (event) => {
-        const command = handleTab(event.shiftKey);
+        const command = $handleTab(event.shiftKey);
         if (command === null) {
           return false;
         }
@@ -866,32 +866,32 @@ export function registerCodeHighlighting(
     ),
     editor.registerCommand(
       INDENT_CONTENT_COMMAND,
-      (payload): boolean => handleMultilineIndent(INDENT_CONTENT_COMMAND),
+      (payload): boolean => $handleMultilineIndent(INDENT_CONTENT_COMMAND),
       COMMAND_PRIORITY_LOW,
     ),
     editor.registerCommand(
       OUTDENT_CONTENT_COMMAND,
-      (payload): boolean => handleMultilineIndent(OUTDENT_CONTENT_COMMAND),
+      (payload): boolean => $handleMultilineIndent(OUTDENT_CONTENT_COMMAND),
       COMMAND_PRIORITY_LOW,
     ),
     editor.registerCommand(
       KEY_ARROW_UP_COMMAND,
-      (payload): boolean => handleShiftLines(KEY_ARROW_UP_COMMAND, payload),
+      (payload): boolean => $handleShiftLines(KEY_ARROW_UP_COMMAND, payload),
       COMMAND_PRIORITY_LOW,
     ),
     editor.registerCommand(
       KEY_ARROW_DOWN_COMMAND,
-      (payload): boolean => handleShiftLines(KEY_ARROW_DOWN_COMMAND, payload),
+      (payload): boolean => $handleShiftLines(KEY_ARROW_DOWN_COMMAND, payload),
       COMMAND_PRIORITY_LOW,
     ),
     editor.registerCommand(
       MOVE_TO_END,
-      (payload): boolean => handleMoveTo(MOVE_TO_END, payload),
+      (payload): boolean => $handleMoveTo(MOVE_TO_END, payload),
       COMMAND_PRIORITY_LOW,
     ),
     editor.registerCommand(
       MOVE_TO_START,
-      (payload): boolean => handleMoveTo(MOVE_TO_START, payload),
+      (payload): boolean => $handleMoveTo(MOVE_TO_START, payload),
       COMMAND_PRIORITY_LOW,
     ),
   );

diff --git a/packages/lexical-code/src/CodeNode.ts b/packages/lexical-code/src/CodeNode.ts
@@ -139,25 +139,25 @@ export class CodeNode extends ElementNode {
 
         return isMultiLine
           ? {
-              conversion: convertPreElement,
+              conversion: $convertPreElement,
               priority: 1,
             }
           : null;
       },
       div: (node: Node) => ({
-        conversion: convertDivElement,
+        conversion: $convertDivElement,
         priority: 1,
       }),
       pre: (node: Node) => ({
-        conversion: convertPreElement,
+        conversion: $convertPreElement,
         priority: 0,
       }),
       table: (node: Node) => {
         const table = node;
         // domNode is a <table> since we matched it by nodeName
         if (isGitHubCodeTable(table as HTMLTableElement)) {
           return {
-            conversion: convertTableElement,
+            conversion: $convertTableElement,
             priority: 3,
           };
         }
@@ -324,15 +324,15 @@ export function $isCodeNode(
   return node instanceof CodeNode;
 }
 
-function convertPreElement(domNode: Node): DOMConversionOutput {
+function $convertPreElement(domNode: Node): DOMConversionOutput {
   let language;
   if (isHTMLElement(domNode)) {
     language = domNode.getAttribute(LANGUAGE_DATA_ATTRIBUTE);
   }
   return {node: $createCodeNode(language)};
 }
 
-function convertDivElement(domNode: Node): DOMConversionOutput {
+function $convertDivElement(domNode: Node): DOMConversionOutput {
   // domNode is a <div> since we matched it by nodeName
   const div = domNode as HTMLDivElement;
   const isCode = isCodeElement(div);
@@ -346,7 +346,7 @@ function convertDivElement(domNode: Node): DOMConversionOutput {
   };
 }
 
-function convertTableElement(): DOMConversionOutput {
+function $convertTableElement(): DOMConversionOutput {
   return {node: $createCodeNode()};
 }