Fix insertNodes insert position at start of inline ElementNode (#5110)

packages/lexical-selection/src/__tests__/unit/LexicalSelectionHelpers.test.ts

@@ -13,6 +13,7 @@ import {
   $patchStyleText,
 } from '@lexical/selection';
 import {
+  $createLineBreakNode,
   $createParagraphNode,
   $createTextNode,
   $getNodeByKey,
@@ -2372,6 +2373,30 @@ describe('LexicalSelectionHelpers tests', () => {
         );
       });
     });
+
+    test('can insert a linebreak node before an inline element node', async () => {
+      const editor = createTestEditor();
+      const element = document.createElement('div');
+      editor.setRootElement(element);
+
+      await editor.update(() => {
+        const root = $getRoot();
+        const paragraph = $createParagraphNode();
+        root.append(paragraph);
+        const link = $createLinkNode('https://lexical.dev/');
+        paragraph.append(link);
+        const text = $createTextNode('Lexical');
+        link.append(text);
+        text.select(0, 0);
+
+        $insertNodes([$createLineBreakNode()]);
+      });
+
+      // TODO #5109 ElementNode should have a way to control when other nodes can be inserted inside
+      expect(element.innerHTML).toBe(
+        '<p><a href="https://lexical.dev/" dir="ltr"><br><span data-lexical-text="true">Lexical</span></a></p>',
+      );
+    });
   });
 
   describe('can insert block element nodes correctly', () => {

packages/lexical/src/LexicalSelection.ts

@@ -1731,7 +1731,7 @@ export class RangeSelection implements BaseSelection {
         );
       }
       didReplaceOrMerge = false;
-      if ($isElementNode(target) && !target.isInline()) {
+      if ($isElementNode(target) && (i === 0 || !target.isInline())) {
         lastNode = node;
         if ($isDecoratorNode(node) && !node.isInline()) {
           if (nodes.length === 1 && target.canBeEmpty() && target.isEmpty()) {