Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Vertical arrow keys move selection and close typeahead menus in tables #5819

Closed
serey-roth opened this issue Apr 4, 2024 · 0 comments · Fixed by #5820
Closed

Bug: Vertical arrow keys move selection and close typeahead menus in tables #5819

serey-roth opened this issue Apr 4, 2024 · 0 comments · Fixed by #5820

Comments

@serey-roth
Copy link
Contributor

serey-roth commented Apr 4, 2024 •
edited

I noticed a bug in the playground. When a typeahead menu is open inside a table cell, pressing the "Arrow Down" or "Arrow Up" key moves the selection vertically instead of navigating through the menu items.

https://www.loom.com/share/92e75e1299434e62838bd40449b77083

Steps To Reproduce

  1. Insert a 2x2 table.
  2. Type '/' in the first cell.
  3. Press "Arrow Down" key.

The current behavior

The typeahead menu disappears, and the selection is moved to the table cell below.

The expected behavior

The selection stays in the current cell, and the next item in the typeahead menu is selected.
serey-roth added a commit to serey-roth/lexical that referenced this issue Apr 4, 2024
@serey-roth
Prevents arrow keys from changing table cell selection when typeahead…
e944c91 
… menu is open.

Fixes facebook#5819
@serey-roth serey-roth changed the title Bug: "Arrow Down" key moves selection and closes typeahead menus in tables Bug: Vertical arrow keys move selection and close typeahead menus in tables Apr 4, 2024
@serey-roth serey-roth mentioned this issue Apr 4, 2024
Merged
serey-roth added a commit to serey-roth/lexical that referenced this issue Apr 4, 2024
@serey-roth
Preserve selection in tables with typeahead menu on arrow key press.
cab9f49 
Fixes facebook#5819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve selection in tables with open typeahead menu on vertical arrow key press serey-roth/lexical
1 participant
@serey-roth