Convert pasted Google Docs Title text into a Heading #2729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acywatson
requested review from
trueadm,
zurfyx,
fantactuka,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
zurfyx
approved these changes
Jul 30, 2022
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
* support GDocs title * handle it better * reorg and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some pretty fragile logic to preserve the formatting of a Google Docs "Title" when pasted into a Lexical editor using the core HeadingNode from @lexical/rich-text.
I do not understand why Google doesn't put something vaguely resembling semantic HTML on the clipboard when users copy from Docs, but I don't think it's going to change and we need to find a more robust way to deal with the idiosyncrasies.
I noticed CKEditor has a whole separate plugin just for handling pasted HTML from Docs. Perhaps the most robust solution would be to not use HTML at all and instead build a conversion between the Google Docs JSON format (that is also on the clipboard) and Lexical.
For now, we have this.