fix: Single anchor element per LexicalTypeaheadMenuPlugin instance #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morphyish
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
Thanks for the contribution @Morphyish! One small fix, but I'll let @tylerjbainbridge review this fully as this was his component.
- Move useEffect hook to position anchorElement to LexicalTypeaheadMenuPlugin - Replace anchorElementRef prop with anchorElement
tylerjbainbridge
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2755
Creating the anchorElement in the Plugin itself and passing it down to the
ShortcutTypeaheadavoid creating a lot of unnecessary nodes that are never removed.Every plugin that relies on
LexicalTypeaheadMenuPluginwill get its anchor element that will then be properly updated with the new position, as it should.Please note that I had to remove the
startTransitionwhen setting theresolutiontonull.The transition was causing the
/menu to flicker, but not the mentions. I'm not sure if it's a specific implementation issue in either of those playground plugins, but as hiding the menu should not cause any unnecessary loading state on the UI, it felt safe to remove.Demo
Lexical.Playground.-.Google.Chrome.2022-08-05.11-31-58_Trim.mp4