fix: set cursor grab when image can be dragged #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciNyan
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Have you tried to set cursor style to document body while dragging? |
Yes, I tried, but it didn't work. I tried adding it to the document body, to the dragged element, to the image in setDragImage, etc.. None of these work, and I'm using Chrome on a mac. |
|
Even with "!important"? 😯 |
Yes... This is strange. Will it work on windows? I'm curious. |
fantactuka
approved these changes
Aug 18, 2022
Looks like browser forces cursor if has drag data: https://bugs.chromium.org/p/chromium/issues/detail?id=1196385 |
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
* fix: set cursor grab when image can be dragged * chore: trigger test * chore: trigger test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
set cursor grab when image can be dragged.
Additionally
I've tried a lot but still can't resolve the problem of not being able to set the cursor when dragging