Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add fallback for code formatting #2833

Merged
merged 2 commits into from
Aug 15, 2022
Merged

fix: add fallback for code formatting #2833

merged 2 commits into from
Aug 15, 2022

Conversation

im-adithya
Copy link
Contributor

Adds fallback for FigmaNode similar to Youtube and Twitter

lexical-.17.mp4

@vercel
Copy link

vercel bot commented Aug 13, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Aug 15, 2022 at 4:57PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Aug 15, 2022 at 4:57PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2022
fantactuka
fantactuka reviewed Aug 14, 2022
View reviewed changes
Copy link
Contributor

@fantactuka fantactuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it use getTextConteny instead? Can override it for all these decorators and simplify this code. It also used for plain text clipboard so copying decorator won't end up with getting nothing for a plan text

@zurfyx
Copy link
Member

zurfyx commented Aug 15, 2022

Thanks but let's work on @fantactuka before merging (sorry, read his comment too late)

@im-adithya
Copy link
Contributor Author

Done!

@thegreatercurve thegreatercurve merged commit 539ef5a into facebook:main Aug 15, 2022
thegreatercurve pushed a commit that referenced this pull request Nov 25, 2022
@im-adithya @thegreatercurve
fix: add fallback for code formatting (#2833)
cc74b0e 
* fix: add fallback for code formatting

* fix
@thegreatercurve thegreatercurve mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantactuka fantactuka fantactuka left review comments

@zurfyx zurfyx zurfyx approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@im-adithya @zurfyx @fantactuka @facebook-github-bot @thegreatercurve