Improve heuristics around node selection and keyboard navigation #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
requested review from
zurfyx,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
thegreatercurve
approved these changes
Aug 24, 2022
acywatson
reviewed
Aug 24, 2022
acywatson
reviewed
Aug 24, 2022
acywatson
reviewed
Aug 24, 2022
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
* Improve heuristics around node selection and keyboard navigation * Improve HorizontalRule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyboard navigation today around node selection is a bit wonky and broken. Specifically, you can't actually select a node using the keyboard arrow keys properly, nor can you escape node selection and move back to range selection using the keyboard arrow keys.
This PR fixes that problem and also tackles a few accessibility issues along the way with image nodes and horizontal rule nodes too.