Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link pasting #2903

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Fix link pasting #2903

merged 2 commits into from
Aug 29, 2022

Conversation

fantactuka
Copy link
Contributor

Pasting link within text moved selection to its end:

Screen.Recording.2022-08-27.at.9.49.07.PM.mov

@vercel
Copy link

vercel bot commented Aug 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Aug 28, 2022 at 2:00AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Aug 28, 2022 at 2:00AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2022
@heesungjang
Copy link
Contributor

Hi @fantactuka, I think there is a typo in your test commit!

"Can insert inline element --> withing <-- text and put selection after it"

@acywatson
Copy link
Contributor

Hi @fantactuka, I think there is a typo in your test commit!

"Can insert inline element --> withing <-- text and put selection after it"

I'm gonna go ahead and merge this and we can make a separate PR to clean up the typo.

@acywatson acywatson merged commit fcdbb7f into main Aug 29, 2022
thegreatercurve added a commit that referenced this pull request Nov 25, 2022
* Remove tab indentation keyboard shortcuts

* Fix selection after pasting inline element

Co-authored-by: John Flockton <johnflockton@fb.com>
@trueadm trueadm deleted the bug-with-link-pasting branch December 18, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants