Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use window of current default view #2918

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Use window of current default view #2918

merged 3 commits into from
Aug 31, 2022

Conversation

trueadm
Copy link
Collaborator

@trueadm trueadm commented Aug 31, 2022

Fixes #2108.

@vercel
Copy link

vercel bot commented Aug 31, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 0:25AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 0:25AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 31, 2022
@trueadm trueadm merged commit 1580cbc into main Aug 31, 2022
@trueadm trueadm deleted the use-default-view branch August 31, 2022 13:53
@trueadm trueadm mentioned this pull request Aug 31, 2022
Closed
thegreatercurve pushed a commit that referenced this pull request Nov 25, 2022
@trueadm @thegreatercurve
Use window of current default view (#2918)
7eb0464 
* Use window of current default view

* Use window of current default view

* Fix codes
@thegreatercurve thegreatercurve mentioned this pull request Nov 25, 2022
Closed
@bilobom bilobom mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Ability to render the editor in an iframe
4 participants
@trueadm @zurfyx @thegreatercurve @facebook-github-bot