Fix npm install on M1 macs #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timebutt
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
acywatson
pushed a commit
that referenced
this pull request
Oct 18, 2022
* Fix npm i on M1 Mac devices * Bump react dependency
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
* Fix npm i on M1 Mac devices * Bump react dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unused
link-preview-generatorpackage which haspuppeteer8.0.0listed as one of its dependencies, which in turn ensures you cannot runnpm iin the root of this project on an M1 Mac. One of the suggestion in this issue mentions you can run your terminal in compatibility mode which is not something you want if you are running a shiny M1 chip ;)