Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeView editor basics #3153

Merged
merged 1 commit into from
Oct 13, 2022
Merged

TreeView editor basics #3153

merged 1 commit into from
Oct 13, 2022

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Oct 10, 2022

The editable can come especially handy when debugging collab initialization

Screen Shot 2022-10-10 at 4 54 43 pm

@vercel
Copy link

vercel bot commented Oct 10, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Oct 10, 2022 at 8:59PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Oct 10, 2022 at 8:59PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2022
acywatson
acywatson approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@acywatson acywatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could plumb through a prop to make this configurable.

@thegreatercurve
Copy link
Contributor

@zurfyx Could you add the same logic into the lexical-devtools as well? (CC @im-adithya).

@zurfyx zurfyx mentioned this pull request Oct 13, 2022
Closed
@zurfyx
Copy link
Member Author

zurfyx commented Oct 13, 2022 •
edited
Loading

Like both suggestions! Added follow ups:

@im-adithya would you be able to help with the devtools please? #3175

@zurfyx zurfyx merged commit eac9050 into main Oct 13, 2022
@im-adithya
Copy link
Contributor

@im-adithya would you be able to help with the devtools please?

Definitely!

acywatson pushed a commit that referenced this pull request Oct 18, 2022
@zurfyx @acywatson
TreeView editor basics (#3153)
0f5f285
thegreatercurve pushed a commit that referenced this pull request Nov 25, 2022
@zurfyx @thegreatercurve
TreeView editor basics (#3153)
ccbb78d
@thegreatercurve thegreatercurve mentioned this pull request Nov 25, 2022
Closed
@thegreatercurve thegreatercurve deleted the editor-tree branch November 25, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@acywatson acywatson acywatson approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zurfyx @thegreatercurve @im-adithya @acywatson @facebook-github-bot