Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fixed broken link #3190

Merged
merged 1 commit into from
Oct 17, 2022
Merged

docs: Fixed broken link #3190

merged 1 commit into from
Oct 17, 2022

Conversation

SimonProper
Copy link
Contributor

Fixed faulty file extension in the url for the useList example in the Commands docs, ending in a 404 page.
Changed the file extension from .ts to .js.

@SimonProper
docs: Fixed broken link
4d8d1d2 
Faulty file extension in url parameter, changed from .ts to .js
@vercel
Copy link

vercel bot commented Oct 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Oct 16, 2022 at 0:08AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Oct 16, 2022 at 0:08AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2022
zurfyx
zurfyx approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, or alternatively we upgrade the link to point to a newer (.ts) commit

@SimonProper
Copy link
Contributor Author

Happy to help!

That seems like a fair point, there are more links in that doc that points to older branches. Is there a reason for that?
I could update all the links to point to the current files in the main branch.

@zurfyx
Copy link
Member

zurfyx commented Oct 17, 2022 •
edited
Loading

Happy to help!

That seems like a fair point, there are more links in that doc that points to older branches. Is there a reason for that? I could update all the links to point to the current files in the main branch.

Not really, they're just outdated. I'll go ahead and merge this for now!

@zurfyx zurfyx merged commit 9adf8db into facebook:main Oct 17, 2022
acywatson pushed a commit that referenced this pull request Oct 18, 2022
@SimonProper @acywatson
docs: Fixed broken link (#3190)
c9f824f 
Faulty file extension in url parameter, changed from .ts to .js
thegreatercurve pushed a commit that referenced this pull request Nov 25, 2022
@SimonProper @thegreatercurve
docs: Fixed broken link (#3190)
29e455e 
Faulty file extension in url parameter, changed from .ts to .js
@thegreatercurve thegreatercurve mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SimonProper @zurfyx @facebook-github-bot