Don't throw if getPreviousSiblings can't find a parent

[acywatson]

This method used to safely return an empty list instead of throwing if the parent isn't found. This changes it back to that approach, so the API matches similar methods and the linked list change remains an implementation detail.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
lexical	✅ Ready (Inspect)	Visit Preview	Dec 12, 2022 at 11:10PM (UTC)
lexical-playground	✅ Ready (Inspect)	Visit Preview	Dec 12, 2022 at 11:10PM (UTC)

[fantactuka]

Curious if it's possible for node to have null parent but non-null siblings. If that's the case then getPrev/NextSiblings will work differently. That said, should we have check for parent in getNextSiblings too to avoid it?

[acywatson]

Curious if it's possible for node to have null parent but non-null siblings. If that's the case then getPrev/NextSiblings will work differently. That said, should we have check for parent in getNextSiblings too to avoid it?

I suppose anything is possible? We never seemed to have that issue before, when this method worked this way.

Maybe the best solution ultimately is to make some of these methods invariant if they're called on RootNode. It's pretty nonsensical. But then you have to check for RootNode everywhere.

[trueadm]

Makes sense. I think I did this by accident

[acywatson]

Makes sense. I think I did this by accident

I figured that might be the case - thanks!