Preserve empty parent during replacement #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
fantactuka
requested review from
trueadm,
zurfyx,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
thegreatercurve
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
LGTM. Accepting to unblock, but maybe @trueadm would have the best insights here.
|
It would probably break some things, but I'm still personally of the opinion that this behavior should be the default. It's not intuitive that removing a specific node would also sometimes remove it's parent. At the same time, it is convenient to not have to check emptiness on your own every time you remove a node. |
|
Pure removal might require parent cleanup but as a part of replacement it does not make much sense |
fantactuka
force-pushed
the
fix-replacement
branch
from
894ac17
to
4417569
Compare
trueadm
approved these changes
Dec 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When node is being replaced we should preserve its empty parent (in case it has
canBeEmpty: false), as otherwise parent might be deleted and replacement fail. E.g., LinkNode hascanBeEmpty: falseand attempting to replace its text node child would fail.Will add test, want to see CI results in case I've missed anything