Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix select all + delete behaviour #3840

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Fix select all + delete behaviour #3840

merged 3 commits into from
Feb 7, 2023

Conversation

trueadm
Copy link
Collaborator

@trueadm trueadm commented Feb 7, 2023

Fixes #3682.

@vercel
Copy link

vercel bot commented Feb 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 2:52PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 2:52PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 7, 2023
@github-actions
Copy link

github-actions bot commented Feb 7, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 30.73 KB (+0.14% 🔺) 615 ms (+0.14% 🔺) 347 ms (-38.37% 🔽) 962 ms
packages/lexical-rich-text/dist/LexicalRichText.js 36.23 KB (+0.12% 🔺) 725 ms (+0.12% 🔺) 353 ms (+5.71% 🔺) 1.1 s
packages/lexical-plain-text/dist/LexicalPlainText.js 36.21 KB (+0.12% 🔺) 725 ms (+0.12% 🔺) 465 ms (+49.01% 🔺) 1.2 s

@trueadm trueadm merged commit f81af3f into main Feb 7, 2023
@trueadm trueadm deleted the fix-delete-all-bug branch February 7, 2023 15:22
@trueadm trueadm mentioned this pull request Feb 8, 2023
Merged
fantactuka added a commit that referenced this pull request Apr 28, 2023
@fantactuka
Adjustments on top of #3840
8c707ef
fantactuka added a commit that referenced this pull request Apr 28, 2023
@fantactuka
Adjustments on top of #3840
aabb5b6
@fantactuka fantactuka mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: select all + delete should remove all blocks
3 participants
@trueadm @thegreatercurve @facebook-github-bot