Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close color pickers on select #3874

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Close color pickers on select #3874

merged 1 commit into from
Feb 10, 2023

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Feb 10, 2023 •
edited

Closes #3871

@vercel
Copy link

vercel bot commented Feb 10, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 10, 2023 at 10:00AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 10, 2023 at 10:00AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 10, 2023
@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 25.96 KB (0%) 520 ms (0%) 103 ms (+105.26% 🔺) 622 ms
packages/lexical-rich-text/dist/LexicalRichText.js 36.68 KB (0%) 734 ms (0%) 73 ms (-17.85% 🔽) 806 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 36.66 KB (0%) 734 ms (0%) 65 ms (-4.3% 🔽) 798 ms

@thegreatercurve thegreatercurve mentioned this pull request Feb 10, 2023
Closed
@thegreatercurve thegreatercurve merged commit 201dd53 into main Feb 10, 2023
@fantactuka fantactuka deleted the bug/close-color-picker-on-select branch July 6, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Styles on collapsed range selections are lost on Firefox
3 participants
@thegreatercurve @trueadm @facebook-github-bot