Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instanceof type checks against HTMLElement and subtypes #3913

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

acywatson
Copy link
Contributor

This should get $generateNodesFromDOM working on the server.

Fixes #3907

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 15, 2023
@vercel
Copy link

vercel bot commented Feb 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 16, 2023 at 3:28PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 16, 2023 at 3:28PM (UTC)

@DaniGuardiola
Copy link

Sweet <3

@github-actions
Copy link

github-actions bot commented Feb 15, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 25.97 KB (0%) 520 ms (0%) 118 ms (+375.49% 🔺) 637 ms
packages/lexical-rich-text/dist/LexicalRichText.js 36.74 KB (+0.09% 🔺) 735 ms (+0.09% 🔺) 128 ms (+86.28% 🔺) 863 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 36.72 KB (+0.09% 🔺) 735 ms (+0.09% 🔺) 88 ms (+64.84% 🔺) 823 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: $generateNodesFromDOM fails in headless mode
5 participants