Change default indent to 40px #4025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanJablo
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
@egonbolton Thanks for the contribution! I'm on board with this change, even if we might initially encounter some issues with nested lists on smaller view ports. I think aiming for browser consistency though is a decent aim though. Mind updating the failing E2Es and I can merge? |
|
Cool! This is done :) |
thegreatercurve
approved these changes
Mar 9, 2023
|
@egonbolton Sorry, I know this is annoying, but do you mind fixing the merge conflicts and then I can merge? |
GermanJablo
requested review from
thegreatercurve
and removed request for
fantactuka,
zurfyx,
trueadm,
tylerjbainbridge and
acywatson
GermanJablo
force-pushed
the
default-indent
branch
from
873c654
to
0db2144
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
40px would be a better default because that's what browsers use for lists.
Indentations in paragraphs, headings, etc, would match that of the lists, and converting the nodes would not generate a strange displacement.
https://www.loom.com/share/6443d73269d04769bd88c00c8f1b973b
You may not see a perfect match with the list indents in the playground, because it's using some styles like
list-style-position: inside.Issue covered here: #3999