Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sticky toolbar to assist in editing large content #4076

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Sticky toolbar to assist in editing large content #4076

merged 4 commits into from
Mar 9, 2023

Conversation

ChronicLynx
Copy link
Contributor

@ChronicLynx ChronicLynx commented Mar 9, 2023 •
edited

Summary

  • Sticky toolbar
  • Removed a duplicate property (resize defined twice)

With a sticky toolbar you can more easily edit content in this situation:

Screen.Recording.2023-03-09.at.8.41.15.AM.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 9, 2023
@vercel
Copy link

vercel bot commented Mar 9, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 5:43PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 5:43PM (UTC)

@ChronicLynx ChronicLynx changed the title Sticky toolbar to assist in editing large content Sticky toolbar to assist in editing large content, Safari resize fix Mar 9, 2023
@ChronicLynx ChronicLynx changed the title Sticky toolbar to assist in editing large content, Safari resize fix Sticky toolbar to assist in editing large content. Safari resize fix. Mar 9, 2023
@ChronicLynx ChronicLynx changed the title Sticky toolbar to assist in editing large content. Safari resize fix. Sticky toolbar feature and bug fix for Safari resize handle Mar 9, 2023
@ChronicLynx ChronicLynx changed the title Sticky toolbar feature and bug fix for Safari resize handle Sticky toolbar to assist in editing large content Mar 9, 2023
zurfyx
zurfyx approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, interestingly, we actually have something like this internally but never ported it to OSS!

@zurfyx zurfyx merged commit cb58398 into facebook:main Mar 9, 2023
@zurfyx zurfyx mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChronicLynx @zurfyx @facebook-github-bot