Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export getNearestEditorFromDOMNode #4079

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Export getNearestEditorFromDOMNode #4079

merged 1 commit into from
Mar 9, 2023

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Mar 9, 2023

This method can come particularly useful for plugins that work over DOMElements (i.e. DOM event listeners) and have to support NestedEditors

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 9, 2023
@vercel
Copy link

vercel bot commented Mar 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Mar 9, 2023 at 6:33PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Mar 9, 2023 at 6:33PM (UTC)

@zurfyx zurfyx changed the title Export getNearestEditorFromDorFromDOMNode Export getNearestEditorFromDOMNode Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.72 KB (0%) 535 ms (0%) 442 ms (+180.54% 🔺) 976 ms
packages/lexical-rich-text/dist/LexicalRichText.js 37.46 KB (+0.03% 🔺) 750 ms (+0.03% 🔺) 397 ms (-36.76% 🔽) 1.2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 37.44 KB (+0.03% 🔺) 749 ms (+0.03% 🔺) 342 ms (-33.85% 🔽) 1.1 s

@zurfyx zurfyx merged commit b363da5 into main Mar 9, 2023
@zurfyx zurfyx mentioned this pull request Mar 24, 2023
Merged
@fantactuka fantactuka deleted the export-get-nearest-editor-from-dom-node branch July 6, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zurfyx @thegreatercurve @facebook-github-bot