Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unresponsive resize handle in Safari #4081

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

ChronicLynx
Copy link
Contributor

@ChronicLynx ChronicLynx commented Mar 9, 2023

This bug was absurd. For whatever reason, the current setup works fine in Chromium and Firefox but is unresponsive in Safari. Using a z-index: -1 half solves the solution but causes the resize handle to disappear and the blinking cursor to disappear.

cursor: text seems to interfere with the resize cursor icon regardless of the stack ordering. Eliminating cursor: text allows the icon to seamlessly switch and the cursor behavior throughout other areas of the app seem to be interpreted by the browser just fine.

Adding the second resize: vertical somehow tells Safari to bring back the blinking cursor and the resize grab handle. It's utterly bizarre... I've ran this by several experienced people and we can't make sense of it other than Safari being Safari. :D

  • This fix seems to not only fix Safari, but still works in Chromium and Firefox so we can avoid doing Safari specific behavior

Current:

Screen.Recording.2023-03-09.at.12.03.44.PM.mov

Fixed:

Screen.Recording.2023-03-09.at.12.04.16.PM.mov

@vercel
Copy link

vercel bot commented Mar 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 7:03PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 7:03PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 9, 2023
@ChronicLynx ChronicLynx changed the title Fix safari resize handle Fix unresponsive resize handle in Safari Mar 9, 2023
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this!

@zurfyx zurfyx merged commit f2d05d0 into facebook:main Mar 9, 2023
@zurfyx zurfyx mentioned this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants