Overflow of logos of action items in Lexical Playground

[gaurab-khanal]

Changed the position to inherit from absolute to fix this issue.

Fixes #4095

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 11, 2023 at 5:20AM (UTC)
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 11, 2023 at 5:20AM (UTC)

[facebook-github-bot]

Hi @gaurab-khanal!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[zurfyx]

On the expected issue picture it looks like the TreeView is slightly decoupled from the editor itself. I would probably a padding at the end of the editor that gives enough room for these actions, WDYT?

[gaurab-khanal]

On the expected issue picture it looks like the TreeView is slightly decoupled from the editor itself. I would probably a padding at the end of the editor that gives enough room for these actions, WDYT?

I am just a beginner who is learning different technologies and to gain more practical real world experiences I am contributing to Open-Source projects. If you think your approach can fix the issue more effectively I would be happy to work on that. But I can't get your approach how can I fix with that approach? Can you guide me?

[gaurab-khanal]

On the expected issue picture it looks like the TreeView is slightly decoupled from the editor itself. I would probably a padding at the end of the editor that gives enough room for these actions, WDYT?

I got it. Should I remove the previous changes and add new changes? I mean adding padding to the editor.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[zurfyx]

Thank you, I like this, just one more thing. The padding should live on the contenteditable as otherwise when clicking on it the editor loses selection. Could you iterate on this please?

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[gaurab-khanal]

Thank you, I like this, just one more thing. The padding should live on the contenteditable as otherwise when clicking on it the editor loses selection. Could you iterate on this please?

Can you elaborate more? As a beginner I can't understand what you are talking about.

[zurfyx]

Thank you, I like this, just one more thing. The padding should live on the contenteditable as otherwise when clicking on it the editor loses selection. Could you iterate on this please?

Can you elaborate more? As a beginner I can't understand what you are talking about.

The padding should be part of the contenteditable div, not the parent. This way when clicking on the padded part the selection (cursor) will move to the editor and will be able to continue typing. Currently, when I click on the 40px you added I have to click back again on the contenteditable to add more content

[gaurab-khanal]

Thank you, I like this, just one more thing. The padding should live on the contenteditable as otherwise when clicking on it the editor loses selection. Could you iterate on this please?

Can you elaborate more? As a beginner I can't understand what you are talking about.

The padding should be part of the contenteditable div, not the parent. This way when clicking on the padded part the selection (cursor) will move to the editor and will be able to continue typing. Currently, when I click on the 40px you added I have to click back again on the contenteditable to add more content

I made the changes. Can you review it?

[gaurab-khanal]

@zurfyx Are you available?

[zurfyx]

LGTM, thank you for iterating on this!

[gaurab-khanal]

LGTM, thank you for iterating on this!

You are welcome