Use broader return types in HorizontalRuleNode

[montlebalm]

Use broader return types inside HorizontalRuleNode to make extending the node easier. Currently, subclasses cannot override these methods with anything other than what's specified by HorizontalRuleNode.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 10, 2023 at 9:47PM (UTC)
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 10, 2023 at 9:47PM (UTC)

[zurfyx]

Thanks! Q: Why would a horizontal rule not be inline? Same for the updateDOM behavior. It feels to me like if you want to create a HorizontalRule that diverges too much from what we have on the playground you may want to create your own Node.

[montlebalm]

Why would a horizontal rule not be inline? Same for the updateDOM behavior

That's a fair point about isInline and I think for all intents and purposes it would be fine to leave it false. As for updateDOM, I don't know all the ways that it's used, but could an extending class want to return true in order to update a DOM attribute?

Mainly, I see the specific return types as an unnecessary limitation. I'd be happy to revert either isInline or updateDOM if you think it's better that way.

[zurfyx]

but could an extending class want to return true in order to update a DOM attribute

You're right! Let's just revert isInline then

[zurfyx]

Thank you!