Improve Documentation #2845 - lexical/list #4107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrySIV
requested review from
zurfyx,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
zurfyx
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
LGTM, thank you for for the detailed documentation! @acywatson, mind having a pass to it since you know more about the impl details behind insertList/removeList and some other methods?
|
Thank you! I will say, I was a bit worried about over explaining the logic, there are a lot of nested if checks and I didn't know if it was more helpful to be specific or general in some cases. |
acywatson
approved these changes
Mar 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation to the lexical/list module @ files: formatList.ts, LexicalListItemNode.ts, LexicalListNode.ts, and utils.ts.