Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch failures in parseEditorState #4109

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Catch failures in parseEditorState #4109

merged 1 commit into from
Mar 14, 2023

Conversation

acywatson
Copy link
Contributor

See this thread:

https://discord.com/channels/953974421008293909/1075554413587996782/threads/1082425526737711115

This should allow a safer path forward cases like this.

@vercel
Copy link

vercel bot commented Mar 13, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 3:11AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 3:11AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2023
@github-actions
Copy link

github-actions bot commented Mar 13, 2023 •
edited

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.85 KB (0%) 538 ms (0%) 358 ms (+260.78% 🔺) 895 ms
packages/lexical-rich-text/dist/LexicalRichText.js 37.69 KB (+0.04% 🔺) 754 ms (+0.04% 🔺) 142 ms (-38.97% 🔽) 896 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 37.66 KB (+0.04% 🔺) 754 ms (+0.04% 🔺) 315 ms (-28.69% 🔽) 1.1 s

@acywatson acywatson merged commit ec38523 into main Mar 14, 2023
@acywatson acywatson deleted the catch-parse branch March 14, 2023 03:59
@zurfyx zurfyx mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acywatson @zurfyx @facebook-github-bot