Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tables Collab E2E #4117

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Fix tables Collab E2E #4117

merged 1 commit into from
Mar 13, 2023

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Mar 13, 2023

The viewport problem seems to be flaky; but adding the same patch to the remaining tests that use the contextual menu should do the trick for now.

Eventually, we have to fix or delete the contextual menu.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2023
@vercel
Copy link

vercel bot commented Mar 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 13, 2023 at 10:26PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 13, 2023 at 10:26PM (UTC)

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.85 KB (0%) 538 ms (0%) 237 ms (-18.95% 🔽) 774 ms
packages/lexical-rich-text/dist/LexicalRichText.js 37.68 KB (0%) 754 ms (0%) 440 ms (+88.04% 🔺) 1.2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 37.65 KB (0%) 754 ms (0%) 315 ms (-38.51% 🔽) 1.1 s

Copy link
Contributor

@fantactuka fantactuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@zurfyx zurfyx merged commit c2a3525 into main Mar 13, 2023
@acywatson acywatson deleted the fix-t branch March 14, 2023 03:06
@zurfyx zurfyx mentioned this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants