Fix table stealing selectionchange #4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurfyx
requested review from
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
fantactuka
reviewed
Mar 20, 2023
| @@ -141,21 +142,29 @@ export function applyTableHandlers( | |||
|
|
|||
There was a problem hiding this comment.
tableElement.addEventListener('mouseleave', () => {
if (isMouseDown) {
return;
}
});Is this one needed at all? (unrelated to changes, just noticed)
There was a problem hiding this comment.
Discussed offline; let's leave this for now as the comment above is important
// Select entire table at this point, when grid selection is ready.
Basically means that it wasn't implemented yet 🙃
fantactuka
approved these changes
Mar 20, 2023
thegreatercurve
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that the
mouseDownlogic inside the table plugin was handling more events than it should.Screen.Recording.2023-03-20.at.3.19.08.PM.mov
Fixes #3785
Fixes #4138