Iterate through the live NodeList instead of copying to an array in $generateNodesFromDOM

[acywatson]

The HTML deserialization design is partially predicated on the user having the ability to manipulate the DOM tree in the conversion functions - this provides virtually limitless flexibility in how incoming HTML can be processed.

Previously, we copied the DOM nodes at the top level to an array, then iterated through that to initiate the HTML -> Lexical transformation. This works fine in most cases, but it can cause an issue in a couple of edge cases where you're trying to combine sibling DOM nodes into a single LexicalNode. There's no way to prevent those sibling nodes from being processed, since they have already been copied to an array, removing them from the DOM does nothing.

Alternative proposed solution was to mark the nodes as "processed" and then ignore them in the next pass, but this doesn't prevent their children from being processed. Also considered allowing the conversion to return "true" to stop further processing, but finally decided that this is just a bug.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
lexical	✅ Ready (Inspect)	Visit Preview	Mar 20, 2023 at 11:22PM (UTC)
lexical-playground	✅ Ready (Inspect)	Visit Preview	Mar 20, 2023 at 11:22PM (UTC)

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
packages/lexical/dist/Lexical.js	26.85 KB (0%)	538 ms (0%)	303 ms (+33.85% 🔺)	840 ms
packages/lexical-rich-text/dist/LexicalRichText.js	37.68 KB (-0.02% 🔽)	754 ms (-0.02% 🔽)	259 ms (-52.88% 🔽)	1.1 s
packages/lexical-plain-text/dist/LexicalPlainText.js	37.66 KB (-0.02% 🔽)	754 ms (-0.02% 🔽)	278 ms (+25.72% 🔺)	1.1 s

[acywatson]

Tables e2e tests are broken on safari at the moment.