-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow excluding specific properties from collab syncing via plugin #4275
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@@ -31,6 +31,7 @@ import { | |||
REDO_COMMAND, | |||
UNDO_COMMAND, | |||
} from 'lexical'; | |||
import {ExcludedProperties} from 'packages/lexical-yjs/src/Bindings'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This references “src”?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, auto-import...good catch. Wonder why integrity job passed...
Moves excluded properties to the Binding to avoid sharing them across plugin instances, allows scoping ignored properties to the node, reducing the likelihood of collisions.
Fixes #3670