Generalize Menu Logic #4284
Merged
Generalize Menu Logic #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
tylerjbainbridge
requested review from
zurfyx,
fantactuka,
acywatson and
thegreatercurve
as code owners
|
LGTM, but I don't think we can merge this just yet as removing modules is a breaking change. Do you want to keep the old modules for now or you want to prioritize the next Lexical version? |
|
LGTM, but it might affect if anyone using old features. |
zurfyx
approved these changes
May 3, 2023
|
@tylerjbainbridge I don't know if you noticed but it broke the < .11 version because of this rename... what's the new guidance to use this API now? Are we expecting no backwards compatibility? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context--
Typeaheads were created and then some parts of the code were reused/adapted for the AutoEmbed menus. This led to a lot of extra code in the
LexicalTypeaheadMenuPlugin.tsx.So in preparation for the upcoming
LexicalContextMenuPluginI've generalized the core menu logic intoLexicalMenus.tsand separated theLexicalNodeMenuPluginthat's used by Embeds into it's own file.Nothing functionally changed here. Things were just moved around/renamed to be more clear.
You can see this in action on the
new-context-menu-v1branch which will have PRs coming soon.