Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit format for text entity node #4382

Merged
merged 1 commit into from Apr 21, 2023
Merged

Inherit format for text entity node #4382

merged 1 commit into from Apr 21, 2023

Conversation

fantactuka
Copy link
Contributor

Fixes #3965

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 21, 2023
@vercel
Copy link

vercel bot commented Apr 21, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2023 6:48pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2023 6:48pm

@github-actions
Copy link

github-actions bot commented Apr 21, 2023 •
edited

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.94 KB (0%) 539 ms (0%) 109 ms (+102.85% 🔺) 648 ms
packages/lexical-rich-text/dist/LexicalRichText.js 37.8 KB (0%) 757 ms (0%) 89 ms (-11.34% 🔽) 845 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 37.78 KB (0%) 756 ms (0%) 64 ms (-7.47% 🔽) 819 ms

@acywatson
Copy link
Contributor

Tests tho

@fantactuka
Copy link
Contributor Author

Tests tho

Forgot to disable new test for plain text, since it won't have any format to inherit 🤷‍♂️

@fantactuka fantactuka merged commit 8b3edbc into main Apr 21, 2023
43 of 45 checks passed
@fantactuka fantactuka deleted the text-entities-format branch April 21, 2023 19:29
This was referenced May 23, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: typing a #hashtag at the end of a line in a new style inserts keystrokes in wrong order
4 participants
@fantactuka @acywatson @zurfyx @facebook-github-bot