Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix markdown list merging #4387

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Fix markdown list merging #4387

merged 4 commits into from
Apr 24, 2023

Conversation

acywatson
Copy link
Contributor

Fixes #3433

@vercel
Copy link

vercel bot commented Apr 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2023 10:04pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2023 10:04pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 21, 2023
@github-actions
Copy link

github-actions bot commented Apr 21, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.94 KB (0%) 539 ms (0%) 443 ms (+165.07% 🔺) 982 ms
packages/lexical-rich-text/dist/LexicalRichText.js 37.8 KB (0%) 757 ms (0%) 212 ms (-68.41% 🔽) 968 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 37.78 KB (0%) 756 ms (0%) 581 ms (-1.28% 🔽) 1.4 s

@acywatson acywatson merged commit 689000f into main Apr 24, 2023
42 of 43 checks passed
This was referenced May 23, 2023
Closed
Merged
@fantactuka fantactuka deleted the md-list-merge branch July 6, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantactuka fantactuka fantactuka approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: One list instead of two seperate
3 participants
@acywatson @fantactuka @facebook-github-bot