Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use provided selection when serializing to HTML #4392

Merged
merged 1 commit into from Apr 24, 2023
Merged

Use provided selection when serializing to HTML #4392

merged 1 commit into from Apr 24, 2023

Conversation

acywatson
Copy link
Contributor

@acywatson acywatson commented Apr 23, 2023 •
edited

Fixes #3705

Adds unit tests for HTML serialization

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2023
@vercel
Copy link

vercel bot commented Apr 23, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2023 5:28pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2023 5:28pm

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.94 KB (0%) 539 ms (0%) 199 ms (+38.77% 🔺) 738 ms
packages/lexical-rich-text/dist/LexicalRichText.js 37.8 KB (+0.01% 🔺) 757 ms (+0.01% 🔺) 469 ms (+59.51% 🔺) 1.3 s
packages/lexical-plain-text/dist/LexicalPlainText.js 37.78 KB (+0.01% 🔺) 756 ms (+0.01% 🔺) 700 ms (+249.6% 🔺) 1.5 s

@acywatson acywatson merged commit 66741ef into main Apr 24, 2023
44 of 45 checks passed
@acywatson acywatson deleted the #3705 branch April 24, 2023 16:26
This was referenced May 23, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: generateHtmlFromNodes ignores selection argument
3 participants
@acywatson @zurfyx @facebook-github-bot