Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting initial state of isSmallWidthViewport #4398

Merged

Conversation

ebads67
Copy link
Collaborator

@ebads67 ebads67 commented Apr 24, 2023

isSmallWidthViewport state is not set correctly when the editor is rendered in a small window. That's why DraggableBlockPlugin is enabled initially when in a small window.

DraggableBlockPlugin-bug

@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 11:36am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 11:36am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2023
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@zurfyx zurfyx merged commit 8448a4e into facebook:main Apr 24, 2023
This was referenced May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants