exportDOM methods for HeadingNode, QuoteNode

[ivailop7]

Adding exportDOM methods for the HeadingNode, QuoteNode (rich-text package). All of the changes are outside of the core, so adding the methods should be safe performance-wise.

Before:

exportDOM-pre.mp4

After:

exportDOMs-post.mp4

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 5, 2023 6:00pm
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 5, 2023 6:00pm

[acywatson]

I don't think any of these apply to list item, but indent especially will not do what we want here, as indent has a different implementation in lists than in elements generally. Also I'm not sure we should be using textIndent anywhere, as it only indents the first line of the text.

[fantactuka]

Agree that it does not make sense for lists, as for textIndent for other nodes seems like this one is the explanation:

lexical/packages/lexical/src/nodes/LexicalParagraphNode.ts

Lines 82 to 85 in aabb5b6

	// padding-inline-start is not widely supported in email HTML, but
	// Lexical Reconciler uses padding-inline-start. Using text-indent instead.
	element.style.textIndent = `${indent * 20}px`;
	}

[ivailop7]

Thank you @acywatson and @fantactuka will remove the textIndent part, I actually didn't realize it was even a thing outside of lists. What would be the correct way to solve this for lists, where should I be looking to solve the alignment on an individual list item level.

[acywatson]

@fantactuka

seems like this one is the explanation:

Yea but if you look at the docs, these do completely different things:

https://developer.mozilla.org/en-US/docs/Web/CSS/text-indent

https://developer.mozilla.org/en-US/docs/Web/CSS/padding-inline-start

I don't understand how that text-indent property is working the same way as padding-inline-start.

@ivailop7

where should I be looking to solve the alignment on an individual list item level.

Alignment in what sense? List indentation is semantic rather than stylistic in Lexical.

[ivailop7]

as in having a single item from a list have justification "right", while the others remain with "left" justification. The bullet icon remains still correctly indented, it's just the text alignment on the row.

[ivailop7]

@acywatson Could I get a second look. I've removed the list item part.