Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable flaky test #4455

Merged
merged 1 commit into from May 4, 2023
Merged

Disable flaky test #4455

merged 1 commit into from May 4, 2023

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented May 4, 2023

This test is flaky everywhere really, any objections towards disabling it for now?

@vercel
Copy link

vercel bot commented May 4, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 9:48pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 9:48pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.98 KB (0%) 540 ms (0%) 232 ms (+76.17% 🔺) 771 ms
packages/lexical-rich-text/dist/LexicalRichText.js 37.84 KB (0%) 757 ms (0%) 479 ms (-21.39% 🔽) 1.3 s
packages/lexical-plain-text/dist/LexicalPlainText.js 37.81 KB (0%) 757 ms (0%) 273 ms (-29.58% 🔽) 1.1 s

acywatson
acywatson approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@acywatson acywatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK - let's be more aggressive with this for now because we need confidence in the CI. Flaky test doesn't help us much.

@zurfyx zurfyx merged commit 4ad4950 into main May 4, 2023
45 checks passed
@zurfyx zurfyx deleted the flaky branch May 4, 2023 22:30
This was referenced May 23, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acywatson acywatson acywatson approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zurfyx @acywatson @facebook-github-bot