Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flow types #4485

Merged
merged 4 commits into from May 11, 2023
Merged

Fix Flow types #4485

merged 4 commits into from May 11, 2023

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented May 11, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 11, 2023
@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 3:14pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 3:14pm

@github-actions
Copy link

github-actions bot commented May 11, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 27.2 KB (0%) 544 ms (0%) 61 ms (+57.36% 🔺) 605 ms
packages/lexical-rich-text/dist/LexicalRichText.js 38.15 KB (0%) 764 ms (0%) 44 ms (-10.06% 🔽) 807 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 38.13 KB (0%) 763 ms (0%) 74 ms (+111.74% 🔺) 837 ms

@@ -5,9 +5,12 @@
* LICENSE file in the root directory of this source tree.
*
* @flow strict
* @generated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't seem to have this in other Flow files in OSS - which way is correct? Not sure off-hand

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch, I just copy-pasted this from the internal source

@zurfyx zurfyx merged commit 9c18a9d into main May 11, 2023
10 of 12 checks passed
@zurfyx zurfyx deleted the type-tr branch May 11, 2023 15:09
This was referenced May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants