Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto embed fix #4530 #4535

Merged
merged 1 commit into from May 23, 2023
Merged

Auto embed fix #4530 #4535

merged 1 commit into from May 23, 2023

Conversation

fantactuka
Copy link
Contributor

Pasting enbeddable url can trigger mutation listener with up to 3 dirty leaves: new node itself and (optional) siblings on both sides of the node:

Before:
See #4530

After:

Screen.Recording.2023-05-23.at.1.36.52.PM.mov

@vercel
Copy link

vercel bot commented May 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview May 23, 2023 5:37pm
lexical-playground ✅ Ready (Inspect) Visit Preview May 23, 2023 5:37pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2023
@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 27.25 KB (0%) 546 ms (0%) 398 ms (+188.35% 🔺) 943 ms
packages/lexical-rich-text/dist/LexicalRichText.js 38.2 KB (0%) 765 ms (0%) 326 ms (-6.61% 🔽) 1.1 s
packages/lexical-plain-text/dist/LexicalPlainText.js 38.18 KB (0%) 764 ms (0%) 312 ms (-45.73% 🔽) 1.1 s

@zurfyx zurfyx merged commit 5b23167 into main May 23, 2023
43 of 45 checks passed
This was referenced May 23, 2023
@fantactuka fantactuka deleted the auto-embed branch July 6, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants