Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : Can't convert paragraph into a header if the first child of the paragraph is a LineBreakNode #4776

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix : Can't convert paragraph into a header if the first child of the paragraph is a LineBreakNode #4776

merged 1 commit into from
Jul 17, 2023

Conversation

naveen8801
Copy link
Contributor

@naveen8801 naveen8801 commented Jul 13, 2023 •
edited

@naveen8801
Fix : firstChild.isInline() is not a fnc when paragraph converted to …
50de2bc 
…heading in a code block having first child as line break
@vercel
Copy link

vercel bot commented Jul 13, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 7:04pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 7:04pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 13, 2023
@dmaklygin
Copy link

Good Job! Thanks!

@naveen8801
Copy link
Contributor Author

Can anyone help me to understand why 2 checks failed out of 45 checks ?

@naveen8801 naveen8801 mentioned this pull request Jul 16, 2023
Closed
@naveen8801
Copy link
Contributor Author

naveen8801 commented Jul 16, 2023 •
edited

This PR will also fix #4696 , I have already updated PR description

@naveen8801 naveen8801 mentioned this pull request Jul 16, 2023
Closed
jwoodhull
jwoodhull reviewed Jul 16, 2023
View reviewed changes
Copy link

@jwoodhull jwoodhull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for fixing this.

@acywatson
Copy link
Contributor

acywatson commented Jul 17, 2023 •
edited

Can anyone help me to understand why 2 checks failed out of 45 checks ?

Just some CI flakiness, I think. Looks fine to me.

@acywatson acywatson merged commit ccf8bf3 into facebook:main Jul 17, 2023
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoodhull jwoodhull jwoodhull left review comments

@acywatson acywatson acywatson approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
5 participants
@naveen8801 @dmaklygin @acywatson @jwoodhull @facebook-github-bot