Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: LexicalClickableLinkPlugin should support ctrl click mode #4565 #4839

Merged
merged 1 commit into from Sep 22, 2023
Merged

feat: LexicalClickableLinkPlugin should support ctrl click mode #4565 #4839

merged 1 commit into from Sep 22, 2023

Conversation

sathishsridhar
Copy link
Contributor

@sathishsridhar sathishsridhar commented Jul 28, 2023 •
edited by zurfyx

Closes #4565

@vercel
Copy link

vercel bot commented Jul 28, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 4:48am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 4:48am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2023
@sathishsridhar
Copy link
Contributor Author

Have raised this PR for #4565 this issue.

After_fix.mov
Before_fix.mov

Kindly, refer the videos for the fix.

zurfyx
zurfyx approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry the delay, this PR fell through the cracks

@zurfyx zurfyx merged commit a3f5252 into facebook:main Sep 22, 2023
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: LexicalClickableLinkPlugin should support ctrl click mode
3 participants
@sathishsridhar @zurfyx @facebook-github-bot