Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Background color only applied to the first cell after dragging table cells #5256

Closed

Conversation

paigekim29
Copy link
Contributor

@paigekim29 paigekim29 commented Nov 20, 2023

This pull request is related to #5255

  • update the handleCellBackgroundColor function to apply the background color to each selected cell

@facebook-github-bot
Copy link
Contributor

Hi @paigekim29!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

vercel bot commented Nov 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 8:14am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 8:14am

@paigekim29
Copy link
Contributor Author

I made the base branch wrong. I will send the new PR. Thank you :)

@paigekim29 paigekim29 closed this Nov 20, 2023
@paigekim29 paigekim29 deleted the bug/table-cell-backgroun-color branch November 20, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants